Skip to content

Conversation

AlanCoding
Copy link
Member

@AlanCoding AlanCoding commented Aug 8, 2025

Description

I've tested with aap-dev now and confirmed POST /api/gateway/v1/role_user_assignments/ yielding

    "created": "2025-08-08T19:46:52.486501Z",

will correspondingly yield this at /api/controller/v2/role_user_assignments/

            "created": "2025-08-08T19:46:52.486501Z",

And they match!

Updated:

Added object_created to the /service-index/ serializer for role assignments, which can be used to validate that the object is the originally-assigned object as an additional check.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Test update
  • Refactoring (no functional changes)
  • Development environment change
  • Configuration change

Self-Review Checklist

  • I have performed a self-review of my code
  • I have added relevant comments to complex code sections
  • I have updated documentation where needed
  • I have considered the security impact of these changes
  • I have considered performance implications
  • I have thought about error handling and edge cases
  • I have tested the changes in my local environment

Testing Instructions

Give permission to object in controller using Gateway API

compare & contrast the serializers

Prerequisites

Steps to Test

Expected Results

Additional Context

Required Actions

  • Requires documentation updates
  • Requires downstream repository changes
  • Requires infrastructure/deployment changes
  • Requires coordination with other teams
  • Blocked by PR/MR: #XXX

Screenshots/Logs

Copy link

sonarqubecloud bot commented Aug 8, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
2 New issues
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@AlanCoding AlanCoding marked this pull request as ready for review September 10, 2025 17:29
Copy link

DVCS PR Check Results:

Could not find JIRA key(s) in PR title, branch name, or commit messages

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
4 New issues
64.6% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant